afnix/infra
1
0
Fork 2
Code Issues 39 Pull requests 9 Projects Releases Packages Wiki Activity

introduce Lix's buildbot in the infrastructure #125

Merged
raito merged 0 commits from refs/pull/125/head into main 2024-10-06 09:55:27 +00:00
Conversation 4 Commits - Files changed -
raito commented 2024-10-05 16:07:49 +00:00 (Migrated from git.lix.systems)
Copy link

As part of our governance decision, we are moving slowly Lix infrastructure in this repository.

This makes the Lix infrastructure code public and benefit from the Floral project sysadmin efforts.

TODO:

  • Fix all remaining secret paths
  • Enroll Lix's buildbot
As part of our governance decision, we are moving slowly Lix infrastructure in this repository. This makes the Lix infrastructure code public and benefit from the Floral project sysadmin efforts. TODO: - [x] Fix all remaining secret paths - [x] Enroll Lix's buildbot
hexchen (Migrated from git.lix.systems) approved these changes 2024-10-06 00:14:44 +00:00
hexchen (Migrated from git.lix.systems) left a comment
Copy link

Looks good to me, apart from two nitpicks. Thanks for working on this1

Looks good to me, apart from two nitpicks. Thanks for working on this1
flake.nix
@ -323,3 +133,3 @@
bagel.monitoring.prometheus-agent.tenant = "floral";
bagel.monitoring.grafana-agent.tenant = "floral";
bagel.secrets.tenant = "floral";
hexchen (Migrated from git.lix.systems) commented 2024-10-06 00:14:44 +00:00
Copy link

C-C C-V mistake? should be @lix-infra

C-C C-V mistake? should be `@lix-infra`
hexchen (Migrated from git.lix.systems) commented 2024-10-06 08:01:57 +00:00
Copy link

Yes :'(

Yes :'(
flake.nix
@ -395,1 +172,3 @@
};
bagel.services.buildbot.tenant = "lix";
}
];
hexchen (Migrated from git.lix.systems) commented 2024-10-06 00:15:57 +00:00
Copy link

would it maybe be sensible to include commonModules in floralInfraModules? seems like a lot of duplication to me on first look.

would it maybe be sensible to include commonModules in floralInfraModules? seems like a lot of duplication to me on first look.
hexchen (Migrated from git.lix.systems) commented 2024-10-06 08:02:06 +00:00
Copy link

Good point!

Good point!
raito commented 2024-10-06 09:16:25 +00:00 (Migrated from git.lix.systems)
Copy link

A part of it was sent in #129, build02 will probably be extracted as well.

All that remains is the Buildbot which is arguably non-trivial to migrate as it implies also a big upgrade in terms of buildbot-nix code, buildbot code, etc.

A part of it was sent in #129, build02 will probably be extracted as well. All that remains is the Buildbot which is arguably non-trivial to migrate as it implies also a big upgrade in terms of buildbot-nix code, buildbot code, etc.
raito commented 2024-10-06 09:26:11 +00:00 (Migrated from git.lix.systems)
Copy link

Final (?) preparations are in #130.

Final (?) preparations are in #130.
raito commented 2024-10-06 09:55:05 +00:00 (Migrated from git.lix.systems)
Copy link

This is now tested, build02 is left to a further PR when I get console access to it to avoid any breakage.

This is now tested, build02 is left to a further PR when I get console access to it to avoid any breakage.
Sign in to join this conversation.
Reviewers
No reviewers
hexchen
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Difficulty/Architectural

Requires changes in multiple pieces of the stack: the Nix interpreter, etc.

  
Difficulty/Easy

Infrastructure beginner friendly tasks

  
Difficulty/Hard

Requires prior knowledge, research and design

  
Help Wanted

Looking for a first task to pick? This one is looking for somefew to do it as well!

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Testing

Issue or pull request related to testing

  
Priority/Critical

The priority is critical

  
Priority/High

The priority is high

  
Priority/Low

The priority is low

  
Priority/Medium

The priority is medium

  
Reviewed/Confirmed

Issue has been confirmed

  
Reviewed/Duplicate

This issue or pull request already exists

  
Reviewed/Invalid

Invalid issue

  
Reviewed/Won't Fix

This issue won't be fixed

  
Security

This is a security issue

  
Silenced Alert

This issue was created to track a silenced alert which needs remediation work.

  
Status/Abandoned

Somebody has started to work on this but abandoned work

  
Status/Blocked

Something is blocking this issue or pull request

  
Status/Need More Info

Feedback is required to reproduce issue or to continue work

  
Status/Postponed

We can do this later

  
Tracking Issue

Umbrella issue of many things at the same time

No labels
Compat/Breaking
Difficulty/Architectural
Difficulty/Easy
Difficulty/Hard
Help Wanted
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Security
Silenced Alert
Status/Abandoned
Status/Blocked
Status/Need More Info
Status/Postponed
Tracking Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: afnix/infra#125
No description provided.
Delete branch "refs/pull/125/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?