WIP: fix(arcana-base-server): complete rewrite of the logic #40

Draft

soyouzpanda wants to merge 3 commits from rewrite-arcana-base-server into main

pull from: rewrite-arcana-base-server

merge into: arcana:main

arcana:main

arcana:build-on-target

arcana:ci

arcana:custom-toplevels

arcana:feature/custom-activation

arcana:feature/colmena-nix-darwin-server

arcana:feature/colmena-netconf-server

arcana:feature/colmena-liminix-server

arcana:fix-eval

arcana:cleanup

arcana:fix-filtering

arcana:nix-defined-activation

Conversation 0 Commits 3 Files changed 6 +334 -420

soyouzpanda commented 2026-01-17 21:57:18 +00:00

Owner

Copy link

Related to #39
Maybe related to #29

We should have used rust traits instead of having massive pile of mess inside ActivationServiceImpl struct definition.
The modification allows better readability while being more flexible, so we can support mutability of TargetHost, so
one can have context inside an ongoing activation of the host.

Related to https://git.afnix.fr/arcana/arcana/issues/39 Maybe related to https://git.afnix.fr/arcana/arcana/issues/29 We should have used rust traits instead of having massive pile of mess inside `ActivationServiceImpl` struct definition. The modification allows better readability while being more flexible, so we can support mutability of `TargetHost`, so one can have context inside an ongoing activation of the host.

soyouzpanda added 3 commits 2026-01-17 21:57:18 +00:00

fix(arcana-base-server): use a functions inside of custom trait instead of passing functions to the service ... 760fdba1c5

Having apply, build and copy_closure functions as service field was a
mistake as it was really messy and not readable.
TargetHost trait simplify the writing as much as possible and allow
other modification such as allowing mut reference and allowing to store
context inside TargetHost struct.

BREAKING CHANGE: As the `ActivationServiceImpl::new` does not have the
three functions as parameters, old implementation of arcana server
should be rewritten to use the struct instead.

fix(arcana-nixos-server): fix implementation to use TargetHost trait from arcana-base-server abc85bf13a

feat(aracana-*-server): support mutability of TargetHost 200aa70fa9

soyouzpanda requested review from raito 2026-01-18 15:03:18 +00:00

soyouzpanda force-pushed rewrite-arcana-base-server from 200aa70fa9 to d5773da424 2026-01-18 15:19:14 +00:00 Compare

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin rewrite-arcana-base-server:rewrite-arcana-base-server

git switch rewrite-arcana-base-server

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff rewrite-arcana-base-server

git switch rewrite-arcana-base-server

git rebase main

git switch main

git merge --ff-only rewrite-arcana-base-server

git switch rewrite-arcana-base-server

git rebase main

git switch main

git merge --no-ff rewrite-arcana-base-server

git switch main

git merge --squash rewrite-arcana-base-server

git switch main

git merge --ff-only rewrite-arcana-base-server

git switch main

git merge rewrite-arcana-base-server

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

raito

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

arcana/arcana!40

No description provided.