Minor coding style fix: lib.getExe instead of ${bin}/bin/bin #391

Merged
kuflierl merged 1 commit from patch-2 into master 2024-10-11 07:37:51 +00:00
kuflierl commented 2024-10-01 21:06:11 +00:00 (Migrated from github.com)

This is a minor change in coding style that removes path references replacing them with lib.getExe.
This makes executable references less dependent on binary names.

Major advantage: the cfg.package option doesn't require the binary name to be "lzbt" anymore.

This is a minor change in coding style that removes path references replacing them with `lib.getExe`. This makes executable references less dependent on binary names. Major advantage: the `cfg.package` option doesn't require the binary name to be "lzbt" anymore.
blitz commented 2024-10-04 07:29:35 +00:00 (Migrated from github.com)

Looks good. Thanks for this cleanup! One minor thing: can you fix your commit names to match the style of the other commits in the repository? Will merge afterwards!

Looks good. Thanks for this cleanup! One minor thing: can you fix your commit names to match the style of the other commits in the repository? Will merge afterwards!
kuflierl commented 2024-10-04 10:50:37 +00:00 (Migrated from github.com)

Looks good. Thanks for this cleanup! One minor thing: can you fix your commit names to match the style of the other commits in the repository? Will merge afterwards!

@blitz I believe that everything could be squashed into a single commit. (I was a bit too verbose while making the commits). Would it be fine if I squashed everything into a single commit?

I am currently away, so I will take care of it ~8h later

> Looks good. Thanks for this cleanup! One minor thing: can you fix your commit names to match the style of the other commits in the repository? Will merge afterwards! @blitz I believe that everything could be squashed into a single commit. (I was a bit too verbose while making the commits). Would it be fine if I squashed everything into a single commit? I am currently away, so I will take care of it ~8h later
blitz commented 2024-10-04 12:38:42 +00:00 (Migrated from github.com)

Sure. One commit is fine. 👍

Sure. One commit is fine. 👍
RaitoBezarius (Migrated from github.com) approved these changes 2024-10-04 15:37:52 +00:00
RaitoBezarius (Migrated from github.com) left a comment

LGTM modulo commit messages.

LGTM modulo commit messages.
kuflierl commented 2024-10-04 19:39:42 +00:00 (Migrated from github.com)

Alright, should be fine now

Alright, should be fine now
kuflierl commented 2024-10-09 19:45:13 +00:00 (Migrated from github.com)

@blitz is the commit name alright?

@blitz is the commit name alright?
blitz (Migrated from github.com) approved these changes 2024-10-11 07:36:28 +00:00
blitz (Migrated from github.com) left a comment

Thank you for taking the time to do this!

Thank you for taking the time to do this!
Sign in to join this conversation.
No description provided.