rokc/rokc
1
0
Fork 0
Code Issues 24 Code Review (Gerrit) Projects Releases Packages Wiki Activity

Add parsing error for choice blocks having multiple defines #22

New issue
Open
opened 2026-03-28 12:24:18 +00:00 by kloenk · 1 comment
kloenk commented 2026-03-28 12:24:18 +00:00
Owner
Copy link

Choice options can only have one main definition place and only very minor second options. Add validations for this

e.g. This is invalid

choice
	prompt "boolean choice"
	default BOOL_CHOICE1
	depends on A
	depends on y

config BOOL_CHOICE0
	bool "choice 0"

config BOOL_CHOICE1
	bool "choice 1"

endchoice

choice
    prompt "foo"

config BOOL_CHOICE0
    bool "ch2"
    
endchoice
Choice options can only have one main definition place and only very minor second options. Add validations for this e.g. This is invalid ```kconfig choice prompt "boolean choice" default BOOL_CHOICE1 depends on A depends on y config BOOL_CHOICE0 bool "choice 0" config BOOL_CHOICE1 bool "choice 1" endchoice choice prompt "foo" config BOOL_CHOICE0 bool "ch2" endchoice ```
kloenk commented 2026-03-28 12:57:59 +00:00
Author
Owner
Copy link

We also have to make sure that default (in the main choice parent) can only be a single symbol and nothing else

We also have to make sure that default (in the main choice parent) can only be a single symbol and nothing else
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ma27-wipwipwip
ci-config
cli-parser
cli
No results found.
Labels
Clear labels   
bug
Something is not working

  
crate/cli
CLI crate

  
crate/core
Core crate

  
crate/parser
Parser crate

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
crate/cli
crate/core
crate/parser
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rokc/rokc#22
No description provided.