afnix/nix-zulip
0
0
Fork 1
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity

sprinkle: define everything in terms of the overlay #5

Open
raito wants to merge 1 commit from fix-packaging into main
pull from: fix-packaging
merge into: afnix:main
Conversation 3 Commits 1 Files changed 4 +15 -29
raito commented 2025-08-25 16:14:39 +00:00
Owner
Copy link

Signed-off-by: Raito Bezarius raito@afnix.fr

Signed-off-by: Raito Bezarius <raito@afnix.fr>
Signed-off-by: Raito Bezarius <raito@afnix.fr>
cobaltcause reviewed 2025-08-25 16:21:47 +00:00
cobaltcause left a comment
Contributor
Copy link

This probably breaks e.g. nix build -f nix output.package.zulip-server doesn't it? Since that won't see the stuff the overlay sets up? I think you'll have to define output = self: { package = ...; } in terms of the overlay too.

This probably breaks e.g. `nix build -f nix output.package.zulip-server` doesn't it? Since that won't see the stuff the overlay sets up? I think you'll have to define `output = self: { package = ...; }` in terms of the overlay too.
nix/default.nix
@ -33,25 +33,22 @@ in
loader = subdir: path: import path self;
};
overlays = {
cobaltcause commented 2025-08-25 16:21:04 +00:00
Contributor
Copy link

s/overlays/overlay/

s/overlays/overlay/
raito commented 2025-08-25 22:09:15 +00:00
Author
Owner
Copy link

Can't there be multiple overlays?

Can't there be multiple overlays?
cobaltcause commented 2025-08-26 03:59:26 +00:00
Contributor
Copy link

Tell you what, how about this: sprinkles/sprinkles#6

Tell you what, how about this: https://git.afnix.fr/sprinkles/sprinkles/pulls/6
raito commented 2025-08-25 22:09:07 +00:00
Author
Owner
Copy link

Right, but do you then re-instantiate nixpkgs with the overlay and inherit?

Right, but do you then re-instantiate nixpkgs with the overlay and inherit?
cobaltcause commented 2025-08-26 03:48:51 +00:00
Contributor
Copy link

Not sure if there's any other way to do it.

Not sure if there's any other way to do it.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix-packaging:fix-packaging
git switch fix-packaging

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix-packaging
git switch fix-packaging
git rebase main
git switch main
git merge --ff-only fix-packaging
git switch fix-packaging
git rebase main
git switch main
git merge --no-ff fix-packaging
git switch main
git merge --squash fix-packaging
git switch main
git merge --ff-only fix-packaging
git switch main
git merge fix-packaging
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: afnix/nix-zulip#5
No description provided.
Delete branch "fix-packaging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?