support extraInstallCommands like grub/systemd-boot loader modules #453

Open
itzwam wants to merge 1 commit from itzwam/xtraInstallCommands into master
itzwam commented 2025-05-02 11:41:50 +00:00 (Migrated from github.com)

Added cfg.extraInstallCommands so we can customize the bootloader like we would have done it using grub / systemd-boot nixos Module

Added cfg.extraInstallCommands so we can customize the bootloader like we would have done it using grub / systemd-boot nixos Module
itzwam commented 2025-05-02 11:46:35 +00:00 (Migrated from github.com)

Maybe we should add extraFiles as well ?

Maybe we should add extraFiles as well ?
blitz commented 2025-05-08 08:23:44 +00:00 (Migrated from github.com)

Thanks for the contribution! Looks good to me.

Would it be possible to have a test for this?

Thanks for the contribution! Looks good to me. Would it be possible to have a test for this?
itzwam commented 2025-05-10 10:45:32 +00:00 (Migrated from github.com)

I will try to implement one

Note that I'm not super familiar with nix OS tests so it will surely needs some adjustments 👍

I will try to implement one Note that I'm not super familiar with nix OS tests so it will surely needs some adjustments 👍
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin itzwam/xtraInstallCommands:itzwam/xtraInstallCommands
git switch itzwam/xtraInstallCommands

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff itzwam/xtraInstallCommands
git switch itzwam/xtraInstallCommands
git rebase master
git switch master
git merge --ff-only itzwam/xtraInstallCommands
git switch itzwam/xtraInstallCommands
git rebase master
git switch master
git merge --no-ff itzwam/xtraInstallCommands
git switch master
git merge --squash itzwam/xtraInstallCommands
git switch master
git merge --ff-only itzwam/xtraInstallCommands
git switch master
git merge itzwam/xtraInstallCommands
git push origin master
Sign in to join this conversation.
No description provided.