tool: split esp paths #74

2023-01-22T17:30:52Z

nikstur commented

2023-01-22 17:30:52 +00:00

(Migrated from github.com)

To access paths on the ESP before or after installing generations, split EspPaths into general EspPaths that only depend on the path to the ESP and EspGenerationPaths which additionally depend on generation specific information (e.g. version number and initrd filename).

This refactoring is in preparation to a larger change to the way systemd-boot is installed.

To access paths on the ESP before or after installing generations, split EspPaths into general EspPaths that only depend on the path to the ESP and EspGenerationPaths which additionally depend on generation specific information (e.g. version number and initrd filename). This refactoring is in preparation to a larger change to the way systemd-boot is installed.

RaitoBezarius (Migrated from github.com) reviewed

2023-01-22 17:30:52 +00:00

blitz (Migrated from github.com) reviewed

2023-01-24 22:45:29 +00:00

rust/tool/src/esp.rs

					
				@ -70,6 +54,38 @@ impl EspPaths {

				    }

				}

blitz (Migrated from github.com) commented

2023-01-24 22:45:29 +00:00

nit: I honestly had a bit of trouble making sense of this. Maybe:

/// Paths to the boot files of a specific generation.
///
/// All of these paths point into the ESP.

nit: I honestly had a bit of trouble making sense of this. Maybe: ``` /// Paths to the boot files of a specific generation. /// /// All of these paths point into the ESP. ```

blitz (Migrated from github.com) reviewed

2023-01-24 22:46:53 +00:00

rust/tool/src/esp.rs

blitz (Migrated from github.com) commented

2023-01-24 22:46:53 +00:00

nit: Maybe:

/// Path to boot files that are not specific to a generation.

nit: Maybe: ``` /// Path to boot files that are not specific to a generation. ```

blitz (Migrated from github.com) approved these changes

2023-01-24 22:48:25 +00:00

blitz (Migrated from github.com) left a comment

Looks pretty straightforward. Feel free to ignore the nits.

nikstur (Migrated from github.com) reviewed

2023-01-24 23:26:09 +00:00

rust/tool/src/esp.rs

					
				@ -70,6 +54,38 @@ impl EspPaths {

				    }

				}

nikstur (Migrated from github.com) commented

2023-01-24 23:26:09 +00:00

I still have a hard time finding a good comment/explanation. Your suggestions are definetely an improvement though.

Sign in to join this conversation.

No reviewers

RaitoBezarius

blitz

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: raito/lanzaboote#74

Rows
Columns